Migrate scheduled-tasks delete from survey to huh#116
Open
Conversation
Add charmbracelet/huh alongside existing survey for incremental migration. Set up testscript-based CLI integration tests with version and help scripts. Add YesNoOptions, YesNoToBool, and PrintQuestionHeader helpers to ui package.
Replace survey.Select with huh.Select[int] for the task picker in scheduled-tasks delete. Uses typed options to store the index directly instead of survey's OptionAnswer pattern.
Add ui/uitest package with helpers for driving huh forms in tests via charmbracelet/x/exp/teatest: RunForm, SelectNth, SelectFirst, TypeAndSubmit, WaitDone. Extract ScheduledTaskDeleteForm from the Cobra handler so the form can be tested independently with simulated keypresses. Tests verify selecting first, second, and last options all bind the correct index.
Includes .tape script for reproducible recording with charmbracelet/vhs.
5 tasks
blsmth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduled-tasks deleteinteractive prompt fromAlecAivazis/survey/v2tocharmbracelet/huhScheduledTaskDeleteFormas a pure form builder function, decoupled from AWSteatest-based TUI tests with simulated keypressestestscriptintegration tests forscheduled-tasksCLI commandsDemo
Recorded with VHS:
Changes
cmd/scheduledTasks.goScheduledTaskDeleteFormbuilderui/questions.goYesNoOptions,YesNoToBool,PrintQuestionHeader) alongside existing survey codeui/uitest/helpers.goRunForm,SelectNth,TypeAndSubmit,WaitDone)integration_test.go.txtarCLI teststestdata/script/*.txtardemo-scheduled-tasks-delete.tapeApproach
The previous attempt (PR #96) tried an all-at-once migration and caused issues. This PR establishes an incremental pattern:
(*huh.Form, result pointers), independently testable without AWS mockstestscriptfor non-interactive CLI behavior,teatestfor real TUI interactionRemaining commands will follow in subsequent PRs (#117–#124).